Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using StandartCharsets and removing UnsupportedEncodingException #3479

Merged

Conversation

Captain1653
Copy link
Contributor

It's my first PR in the project. Advice will be appreciated :) . It's only small refactoring. Should I create an issue for it? I can do it and link my commit.

Kind regards.

@Captain1653
Copy link
Contributor Author

I signed OCA

@romain-grecourt
Copy link
Contributor

/oca-checked

@romain-grecourt
Copy link
Contributor

/trigger

@romain-grecourt
Copy link
Contributor

@Captain1653 You touched files that need to have the year in the copyright header updated. You can use ./etc/scripts/copyright.sh to run the check.

I would also advise you to run ./etc/scripts/checkstyle.sh just in case.

@romain-grecourt
Copy link
Contributor

/trigger

@romain-grecourt romain-grecourt merged commit 85a4ee6 into helidon-io:master Oct 8, 2021
@Captain1653 Captain1653 deleted the use-standart-charsets branch October 8, 2021 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants